search

polyanskiy / refractiveindex.info-database

Database of optical constants
Creative Commons Zero v1.0 Universal
161 stars 57 forks source link

Fix yml files, add test, add workflow #49

Closed mfschubert closed 1 week ago

mfschubert commented 1 week ago

Hi @polyanskiy , thanks for maintaining this repo. I depend on it via https://github.com/toftul/refractiveindex and find it extremely helpful.

I noticed that in yesterday's update, four yml files were improperly formatted and therefore cannot be parsed. This PR fixes the four files, and also adds some testing to help ensure that all files in the database can always be parsed. It also adds a github action which will run with every PR, to help keep things in a healthy state.

Thanks again for your work on this repo. Please let me know if you have any questions or if I can be helpful.

polyanskiy commented 5 days ago

Hi @mfschubert,

Thank you for identifying the bugs and adding the new scripts!

Would it be possible for you to add some comments and outputs to the test_parse.yml file to make it clearer how to use the script and what it’s doing?

Thanks again for your contributions!

mfschubert commented 5 days ago

Hi @polyanskiy, sure I will be happy to do so. I am away for one week but can get to this early next week.