search

polybar / polybar-scripts

This is a community project. We write and collect scripts for polybar!
The Unlicense
2.46k stars 338 forks source link

Resize screenshots in README to equal height #382

Closed totoroot closed 2 years ago

totoroot commented 2 years ago

IMO it would look way better if screenshots of the polybar modules were all of equal height. Since standard Markdown image notation does not allow for sizing, the HTML image tag has to be used to achieve equal height for all screenshots. The HTML tag is supported by GitHub and most user clients, so it should not cause rendering problems.

Let me know if you would like to size them to have bigger or smaller height.

totoroot commented 2 years ago

Just for reference, this is how it would look: image

x70b1 commented 2 years ago

Thanks for your work on this! I am a bit unsure if this a good idea. One thing is that now the link to the script is missing. It leads to the screenshot but not to the script README.md. The other question is if the scaled screenshots are looking that good.

totoroot commented 2 years ago

Thanks for your work on this! I am a bit unsure if this a good idea. One thing is that now the link to the script is missing. It leads to the screenshot but not to the script README.md. The other question is if the scaled screenshots are looking that good.

Yeah, it doesn't really look that much better. I wasn't sure if it would actually be an improvement, but the script was whipped up quickly, and I thought I'd let you decide. I'll close this PR then.