search

polybar / polybar-scripts

This is a community project. We write and collect scripts for polybar!
The Unlicense
2.46k stars 338 forks source link

openweathermap-fullfeatured.sh: curl -sf missing double quotes #395

Closed FromWau closed 1 year ago

x70b1 commented 1 year ago

Thanks for this! Why do you assume the quotes are required here?

FromWau commented 1 year ago

Thanks for this! Why do you assume the quotes are required here? Hi, curl fails for me without the quotes.

x70b1 commented 1 year ago

This is interesting. I have no problems with it. Which shell do you use?

FromWau commented 1 year ago

This is interesting. I have no problems with it. Which shell do you use?

I am using zsh and apparently does zsh (and fish) treat the ? in the URL as a wildcard.

zsh -c 'curl -sf https://location.services.mozilla.com/v1/geolocate?key=geoclue' will cause: zsh:1: no matches found: https://location.services.mozilla.com/v1/geolocate?key=geoclue Escaping the ? via \ or by adding quotes resolves it.

x70b1 commented 1 year ago

Okay, that makes sense. We should update the other openweathermap scripts than also.

Would you like to do it?

FromWau commented 1 year ago

Sure, i can do that.

x70b1 commented 1 year ago

Perfect! I merged your PR. Thanks for your work!