search

polybar / polybar-scripts

This is a community project. We write and collect scripts for polybar!
The Unlicense
2.46k stars 338 forks source link

fix pipewire-microphone #440

Closed allddd closed 10 months ago

allddd commented 10 months ago

The --list-targets option was removed from pw-cat in ecff225b, which broke the script (#436). In my opinion it's not really necessary, since it can be done with pactl. Other changes mainly concern style/efficiency.

x70b1 commented 10 months ago

Thanks for the update! Why is a trailing underscore required in the function names?

allddd commented 10 months ago

@x70b1

Why is a trailing underscore required in the function names?

It's just a naming convention commonly used when writing shell/bash. It helps distinguish internal functions from external functions/tools, but one could argue that it's hardly necessary in a 40-line script.

If you do not like it, I can remove it, it will not affect functionality.

x70b1 commented 10 months ago

Its a bid odd at this place. I would also remove the vim config line. Everything else is fine. I would pull it after these 2 small changes.

x70b1 commented 10 months ago

Thanks!

skjnldsv commented 9 months ago

Why not pactl get-default-source ? :)