fix(generators): Add support for eventstruct

polybar / xpp

xpp - A C++11 RAII wrapper for XCB

Other

7 stars 11 forks source link

fix(generators): Add support for eventstruct #11

Closed patrick96 closed 6 years ago

patrick96 commented 6 years ago

Newer xcb-proto commits after the 1.12 release require the 'eventstruct' key in the output dictionary, otherwise the generator crashes.

I don't see a need for xpp to actually support the eventstruct key and thus it uses a NOP lambda function

patrick96 commented 6 years ago

I was able to both reproduce the error by using the latest xcb-proto commits and build successfully using this patch. I think we should wait with merging this until someone over at https://github.com/jaagr/polybar/issues/973 also confirms that this is working.

bascht commented 6 years ago

Can confirm this works. :-) Built Polybar master (jaagr/polybar@f5316137237dc120252852fc9ff97de34e8bdae6) successfully on OpenSuSE 20180128 by switching the xpp submodule to this branch. 👍