search

polybar / xpp

xpp - A C++11 RAII wrapper for XCB
Other
7 stars 11 forks source link

fix(cmake): Use right dir for xml proto files #12

Closed patrick96 closed 6 years ago

patrick96 commented 6 years ago

As described in jaagr/polybar#750 ${XCBPROTO_PREFIX}/share/xcb may not point to the directory containing the xml proto files

If cmake 3.4 or up is used, the proper path (stored in the xcbincludedir variable in xcb-proto.pc) can be fetched. Older versions fall back to the way it was done before

jaagr commented 6 years ago

Is there anything left to be done here? The reason I ask is because the pull-request is still tagged with [WIP].

patrick96 commented 6 years ago

I'm still waiting on confirmation from @fedelodo that this actually works.

patrick96 commented 6 years ago

We just got confirmation that this works on Exherbo. So I think it's ready to be merged.