search

polybar / xpp

xpp - A C++11 RAII wrapper for XCB
Other
7 stars 11 forks source link

Drop python2 #17

Closed patrick96 closed 5 years ago

patrick96 commented 5 years ago

So this didn't take as much work as I thought.

On my machine this code generates the same .hpp files as the python2 code (except for the order of classes).

@Lomadriel could you please try this and see if the files generated in include/xpp/proto are the same for you as well (make sure to clear the directory before you build).

Fixes polybar/polybar#1892

Lomadriel commented 5 years ago

Just a little question, did you pass on all the code or did you fix problems when your python script crashed ?

patrick96 commented 5 years ago

I ran make xpp and then tried to fix whatever error popped up until it no longer crashed.

It's very well possible that there are some pieces of code that won't work with python3.

I will try to run some linters over the code to see if I find anything. Honestly I'm not sure how to find all incompatibilites, even the Porting Guide suggests having high code coverage to find errors.

patrick96 commented 5 years ago

I fixed some more issues I found with other linters. But they seem to be in code that is never called anyway.

I think there really isn't another way than break the build for users where other pieces of the code are called.