polybase / zk-benchmarks

https://zkbench.dev
40 stars 4 forks source link

Add polylang benchmarks #26

Closed mateuszmlc closed 1 year ago

mateuszmlc commented 1 year ago

Fib is really slow because we use f32 ops (both for loop's i and the other variables). When we add inference it will use u32 or i32.

linear[bot] commented 1 year ago

ENG-1004 Polylang benchmarks

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zk-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 2:37pm
calummoore commented 1 year ago

We don't have an i32/u32 type we could use instead of f32?

mateuszmlc commented 1 year ago

We don't have an i32/u32 type we could use instead of f32?

We do. There is a way we can use them before adding inference, by taking them as parameters to main - function main(i: u32, a: u32, b: u32, c: u32), although in practice if a user wrote the code as we have right now, they would be using f32, as that's the default for all numbers right now (I think we wanted to match JS in this aspect).

calummoore commented 1 year ago

Nice!