polybiusproxy / hxCodec

Haxe library for native video playback on HaxeFlixel and OpenFL.
https://lib.haxe.org/p/hxCodec
Mozilla Public License 2.0
109 stars 71 forks source link

Rendering Overhaul. #268

Closed RapperGF closed 1 year ago

RapperGF commented 1 year ago

This PR aims to fix rendering performance while improving video framerate - Inspired from hxCodecPlus.

The rendering is now locked at 16ms which is 60 fps video playback.. Here's a list of changes.

This does not solve the haults mid playthrough I'm not sure what causes those on this version of hxcodec my guess is LibVLC.

image image

https://user-images.githubusercontent.com/84131849/236664280-258743ca-225a-43ef-9bc9-401da2b15663.mp4

polybiusproxy commented 1 year ago

Why lock the rendering at 16ms?

MAJigsaw77 commented 1 year ago

They don't like 30 fps videos ig xd

RapperGF commented 1 year ago

I locked it at 16ms mostly for testing as this gave the best performance at 60 fps but its worth noting that the rendering delta does not change the actual fps of the video if you play a 30 fps video when the delta is at 16 also im workin on screen tearing fixes so rendering at 16 on a 60hz would help a tiny bit.

MAJigsaw77 commented 1 year ago

This is now getting closed as the pr is pushed on this commit rn.