polyend / TrackerBetaTesting

Beta firmware and reporting. For official releases go to https://polyend.com/downloads/
251 stars 24 forks source link

[1.3.0 beta 2] Can’t overdub if there’s a note without a note off command #469

Closed TwistedGenetics closed 1 year ago

TwistedGenetics commented 3 years ago

Hi

When overdubbing, notes won’t record unless the existing notes have a note off value. I have enclosed a video to show this bug.

https://share.icloud.com/photos/08obyKyZEmIERyjaCWwcJl4fQ

Thanks

ghost commented 3 years ago

Same here

ambv commented 3 years ago

We need to figure out what the design here should look like. The idea behind not recording notes into tracks with open notes is to not cut them off if new notes can be recorded on a different track instead. This works as intended but I agree we are missing support for a case where the user wants to overdub regardless of the current track state. If you have suggestions on how this could work, we're happy to hear them.

TwistedGenetics commented 3 years ago

For me if I want to overdub it’s to add notes to and existing instrument I missed the first time around. So if these new notes cut existing notes then so be it ( they would have cut if recorded in correct order the first time ). With regards to overdubbing new instruments on an existing track I think that if a note is already occupied when you hit a new note then no note should be added, only empty spaces can be occupied?

XANi commented 3 years ago

My take on improving it for live record:

That way it would be possible, if say you wanted to have another take at a part, just hold delete and play to replace it with new notes, or hold shift if you just wanted to change/add new ones

We need to figure out what the design here should look like. The idea behind not recording notes into tracks with open notes is to not cut them off if new notes can be recorded on a different track instead. This works as intended but I agree we are missing support for a case where the user wants to overdub regardless of the current track state. If you have suggestions on how this could work, we're happy to hear them.

@ambv simplest fix for that would be

Then if I want to say work on one track I can just disarm all other ones. Option to delete one under cursor would also be nice

bambrose commented 3 years ago

I think it should be destructive overdubs.. I.e if you don't want to overwrite stop playing. Playing and having notes not hit just feels like something is broken

XANi commented 3 years ago

@bambrose I had the same feeling and was actually insanely confused at first when it happened. Then I noticed spilling notes so I unarmed rest of the tracks. Then was surprised that I couldn't add anything. Only after finding this bug I have realized it won't add because there was no OFF after the note.

PITmast commented 3 years ago

Hi XANi Finally I got what’s going on with midi live recording. So it looks like missing OFFs cause strange behaviors after erasing entire midi track during playback. Thanks!

I absolutely agree it’s worth to implement something to make work with midi more convenient because this gear can be the best mobile midi sequencer ever with absolutely unique advantage samples player.

Your ideas are great, maybe except keeping any PT key pressed during recording (both hands on keyboard). I absolutely support you. Poly, please consider it.

Regards

MortalJS commented 2 years ago

Hi @TwistedGenetics Can you check if the problem occurs in firmware 1.5?

PITmast commented 2 years ago

Hello everyone It’s still there in 1.5

regards