fix: init functions and AllowPair fields

ldez commented 7 months ago

golangci-lint uses go-errorlint as a lib, then init functions can be a problem because they are always called.

The PR removes the need to use init functions:

to load allowedErrorsMap
for the flags (this fixes a regression: issue #21 has been fixed with f57ae321623d3e45f7ca6010c6c11e2dbf53e849 but aed56418cd3705e4635c1be0c8951462bfeafb48 inverts the expected behavior).

The new signature of NewAnalyzer allows to set use options but the fields of AllowPair are not exposed, so it's impossible to use WithAllowedErrors or WithAllowedWildcard. The PR exposes the fields err and fun of the structure AllowPair.

Related to #69

polyfloyd commented 7 months ago

Nice, thanks!

ldez commented 7 months ago

@polyfloyd could you create a new tag?

polyfloyd commented 7 months ago

Yes! Of course. CI should be running now

ldez commented 7 months ago

Thank you :heart:

polyfloyd / go-errorlint

fix: init functions and AllowPair fields #74