search

polyfloyd / rust-id3

A rust library for reading and writing ID3 metadata
MIT License
245 stars 47 forks source link

Adds support for reading/writing TDOR frames #105

Closed agersant closed 2 years ago

agersant commented 2 years ago

This frame is a ID3v2.4 addition (similar to TDRL) which encodes Original Release Date.

I initially had a more ambitious version of this change handling upgrading from TOR/TORY frames, using logic similar to convert_2_to_3_and_back. However, if we stored TOR/TORY frames as TDOR for the in-memory representation, we would then have to ensure they get trimmed to only a year (without month, day, etc.) when encoding as a 2.3 or 2.2 tag. There is currently nowhere suitable to host this logic, so I trimmed the PR to direct manipulation of TDOR frames only.

polyfloyd commented 2 years ago

Thanks!