polyfloyd / rust-id3

A rust library for reading and writing ID3 metadata
MIT License
245 stars 47 forks source link

remove year, date_recorded, date_released #49

Closed TianyiShi2001 closed 4 years ago

TianyiShi2001 commented 4 years ago

All readable and settable fields are also removable, except for these three fields. Is there a particular reason for this? If not I'll make a PR to add a .remove_*() method for these three fields.

polyfloyd commented 4 years ago

The named functions are fairly incomplete and written based on how common these fields are, I think. After inheriting this codebase, this was not a concern of mine.

Feel free to submit a PR :)

TianyiShi2001 commented 4 years ago

I agree that exact dates are not common but IMO 'year' is a quite essential attribute (probably because I'm coming from an academic background and all bibliography entries must have a year).