search

polyfloyd / rust-id3

A rust library for reading and writing ID3 metadata
MIT License
245 stars 47 forks source link

Use of unstable stream_position #68

Closed ghosty141 closed 3 years ago

ghosty141 commented 3 years ago

For a project of mine I'm using rust (stable) and when building I get the following message:

error[E0658]: use of unstable library feature 'seek_convenience'
...
let id3_tag_pos = file.stream_position()?;

When checking out the function it says "this is equivalent to self.seek(SeekFrom::Current(0))." which would work in stable. How about replacing the stream_position calls with seek(SeekFrom::Current(0)) to make this library fully compatible with stable rust?

Have you tried this/what is the reason this unstable feature is needed?

polyfloyd commented 3 years ago

At first I was confused because the CI should have caught this. But stream_position has been stabilized in Rust 1.51, which is the latest stable version. Updating your installed Rust version should fix it :+1:

ghosty141 commented 3 years ago

Oh I didn't notice, thanks 👍 What threw me off is, that the tracking issue is still open and I didn't see where it was added to stable rust. https://github.com/rust-lang/rust/issues/59359