search

polyfy / polylith

A tool used to develop Polylith based architectures in Clojure.
Eclipse Public License 1.0
519 stars 48 forks source link

link to affected 3rd party test runners in docstring #426

Closed seancorfield closed 8 months ago

seancorfield commented 8 months ago

Signed-off-by: Sean Corfield sean@corfield.org

imrekoszo commented 8 months ago

@seancorfield thanks for documenting this.

Do you think it would be worth making the contract explicit? If yes, have you got any suggestions on a way to do that?

seancorfield commented 8 months ago

Specs for the arguments that cover the required keys and an s/fdef on create itself -- with instrumentation enabled for the tests (I'm assuming there are some tests for create-test-runner).

For now, just a great big reminder in the docstring is probably enough :)