Closed aitzkovitz closed 10 months ago
@aitzkovitz hmm i don't a PR or commit with the updated ws spec
@aitzkovitz hmm i don't a PR or commit with the updated ws spec
@aitzkovitz hmm i don't a PR or commit with the updated ws spec
Hmm i was looking at this issue and saw that it was reference by another issue titled [WIP] Update Launchpad Websocket specs #332. But that link is broken, so maybe that work hasn't ben done yet. Do you think this PR depends on that work?
@aitzkovitz yeah if you're updating the websocket client, you should update the spec too, it's just a simple command in the makefile
@aitzkovitz yeah if you're updating the websocket client, you should update the spec too, it's just a simple command in the makefile
Oh i see what you're saying. I ran both the
@aitzkovitz yeah if you're updating the websocket client, you should update the spec too, it's just a simple command in the makefile
Oh i see what you're saying. I ran both the websocket and rest spec update commands originally. But we haven't released any spec changes (we're waiting until next week) so those should look the same aside from any other spec changes which have gone out since the last release.
This PR is the one I had to update ws specs, but I made it before we decided not to modify the existing Launchpad value
field. I haven't had the chance to go back and update it since, but I should be able to later today.
@aitzkovitz I think we also need to update this handleData method so FMV data can be unmarshalled into the FMV model.
yeah i believe @aliche-a has a PR for the ws specs update somewhere? I think we're waiting to release that