Bug fix for FMV with stocks, options, forex, or crypto

[justinpolygon]

This PR addresses a bug related to the support of BusinessFairMarketValue (FMV) in different market types. Previously, our supports function in the Market type only checked if a topic was within predefined min-max ranges for each market type (Stocks, Options, Forex, Crypto). This implementation did not account for FMV, which falls outside these ranges but is relevant and essential for these market types.

Changes Made:

• Modified the supports function to include a check for BusinessFairMarketValue.
• Ensured FMV is now supported for Stocks, Options, Forex, and Crypto markets.
• Added a clarifying comment in the code to explain the rationale behind the additional check for FMV.

Impact:

• This fix allows FMV to be recognized as a supported topic in the relevant market types, aligning the functionality with our intended feature set.

Here's a text script:

package main

import (
    "os"
    "os/signal"

    polygonws "github.com/polygon-io/client-go/websocket"
    "github.com/polygon-io/client-go/websocket/models"
    "github.com/sirupsen/logrus"
)

func main() {
    log := logrus.New()
    log.SetLevel(logrus.DebugLevel)
    log.SetFormatter(&logrus.JSONFormatter{})
    c, err := polygonws.New(polygonws.Config{
        APIKey: os.Getenv("POLYGON_API_KEY"),
        Feed:   polygonws.BusinessFeed,
        Market: polygonws.Stocks,
        Log:    log,
    })
    if err != nil {
        log.Fatal(err)
    }
    defer c.Close()

    // FMV
    _ = c.Subscribe(polygonws.BusinessFairMarketValue, "*")

    if err := c.Connect(); err != nil {
        log.Error(err)
        return
    }

    sigint := make(chan os.Signal, 1)
    signal.Notify(sigint, os.Interrupt)

    for {
        select {
        case <-sigint:
            return
        case <-c.Error():
            return
        case out, more := <-c.Output():
            if !more {
                return
            }
            switch out.(type) {
            case models.FairMarketValue:
                log.WithFields(logrus.Fields{"fmv": out}).Info()
            default:
                log.WithFields(logrus.Fields{"unknown": out}).Info()
            }
        }
    }
}

[justinpolygon]

I'm not sure what the lint errors are about these are unrelated to my change.

[ttong-ai]

Would you be able to merge this and publish a new release? We are waiting for this release :-)

[justinpolygon]

@ttong-ai FYI - v1.16.2 has been released with this fix.