search

polygon-io / client-jvm

The official JVM client library SDK, written in Kotlin, for accessing the Polygon REST and WebSocket API.
50 stars 33 forks source link

Bug in PolygonWebSocketClient implementation #144

Closed jbaron closed 8 months ago

jbaron commented 9 months ago

In the PolygonWebSocketClient a key part is missing from the code. Frames get converted into messages, but these messages are then discarded.

The below snippet includes the line that should be added:

 if (frame is JsonObject) {
            val message =
                    when (market) {
                        Market.Stocks -> parseStockMessage(frame)
                        Market.Options -> parseOptionMessage(frame)
                        Market.Indices -> parseIndicesMessage(frame)
                        Market.Forex -> parseForexMessage(frame)
                        Market.Crypto -> parseCryptoMessage(frame)
                        Market.LaunchpadStocks -> parseLaunchpadMessage(frame)
                        Market.LaunchpadOptions -> parseLaunchpadMessage(frame)
                        Market.LaunchpadForex -> parseLaunchpadMessage(frame)
                        Market.LaunchpadCrypto -> parseLaunchpadMessage(frame)
                        Market.BusinessStocks -> parseBusinessMessage(frame)
                        Market.BusinessOptions -> parseBusinessMessage(frame)
                        Market.BusinessForex -> parseBusinessMessage(frame)
                        Market.BusinessCrypto -> parseBusinessMessage(frame)
                        is Market.Other -> parseOtherMessage(frame)
                    }
            collector.add(message) // IN ORIGINAL CODE THIS IS MISSING
        }
upMKuhn commented 8 months ago

+1

justinpolygon commented 8 months ago

Thanks for reporting. I'm looking at this now.

justinpolygon commented 8 months ago

Fixed -- thank for reporting this @jbaron!