search

polygon-io / client-python

The official Python client library for the Polygon REST and WebSocket API.
https://polygon-api-client.readthedocs.io/
MIT License
744 stars 204 forks source link

Update ws init lint formatting #661

Closed justinpolygon closed 2 months ago

justinpolygon commented 2 months ago

Attempting to fix lint formatting issue with https://github.com/polygon-io/client-python/pull/658.

justinpolygon commented 2 months ago

Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?

jbonzo commented 2 months ago

Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?

@justinpolygon Is there something preventing us from putting the comprehensive fix in this single PR?

justinpolygon commented 2 months ago

@justinpolygon Is there something preventing us from putting the comprehensive fix in this single PR?

Doh, that's such a good idea! I just needed a second set of eyes. Yeah, I'll test that. Thank you!

justinpolygon commented 2 months ago

That fixed it. Thanks @jbonzo!

justinpolygon commented 2 months ago

Thanks again for the suggestion and help @jbonzo! Cheers.