search

polygon-io / client-python

The official Python client library for the Polygon REST and WebSocket API.
https://polygon-api-client.readthedocs.io/
MIT License
744 stars 204 forks source link

Is there a particular reason `urllib3<2.0.0,>=1.26.9` is required? #692

Closed jrosebr1 closed 1 week ago

jrosebr1 commented 1 week ago

The reason I ask is because a project I'm working on requires urllib3>=2.0.0.

I installed urllib3==2.2.1 and polygon-api-client and my codebase and tests still worked (I predominately use only the get_aggs method).

Should I be worried about using urllib3 v2?

Thanks so much.

justinpolygon commented 1 week ago

Hey @jrosebr1. TL;DR -- nothing to be concerned about.

We can probably just update it. When we last looked at it we needed to do some testing to make sure everything still worked as expected so that delayed the release. I think all that's done now so we can go ahead. Thanks for pointing that out. We're going to do a new release shortly here and I'll make sure that's updated too.

Cheers

jrosebr1 commented 1 week ago

Wow, thanks so much for the quick reply. Really appreciate it 🙏

I'll keep an eye out for the latest version 😄

justinpolygon commented 1 week ago

No worries. I'll keep this open and ping you when it's out. Cheers!

justinpolygon commented 1 week ago

Urllib has been updated to 2.x and a new v1.14.0 release published https://github.com/polygon-io/client-python/releases/tag/v1.14.0. Thanks for the suggestion here!

You can upgrade via pip install -U polygon-api-client.

jrosebr1 commented 5 days ago

Thanks so much @justinpolygon! ❤️