polylang / dynamo

Improves the WordPress translations performance
GNU General Public License v2.0
6 stars 1 forks source link

Modify comments for PHPUnit tests of same string translated by __() and _n() #16

Closed Chouby closed 2 years ago

Chouby commented 2 years ago

In #15 we fixed an issue that we believed to be a confict with WPML. In fact, nothing prevents a developer to pass the same string to __() and _n(). This is the case for example in Query Monitor where the we can find __( '%s S' ) and _n( '%s S', '%s S' ). The MO format is not able to distinguish the two cases as the key is always the singular for in a plural string. So only one translation is stored. Not sure if all softwares take care about this case. GlotPress seems to export the plural form. Anyway, we need to change the comments which refer to a wrong usage in WPML.