search

polymerdao / ibc-go

Interblockchain Communication Protocol (IBC) implementation in Golang.
https://ibc.cosmos.network/
MIT License
11 stars 13 forks source link

add a noproof mode that disables connection keeper verifications #20

Closed nicopernas closed 8 months ago

dshiell commented 1 year ago

Before merging we probably should think carefully about this to make sure this is upstream-able work. Thinking about alternatives, this approach seems the safest way to do this, but what do others think?

nicopernas commented 1 year ago

I wasn't thinking to upstream this change to be honest. And it's ok if that means not merging this PR. We do need to build our chain against this patch though or nothing will work.

What I can do is reference the npernas/nooproof-mode branch from our chain for the time being. It's an extra step we need to take if we want to add more changes to our fork but it keeps the change out of it. Thoughts?

alfredo-stonk commented 1 year ago

IMO we should leave this PR open but never merge it to our 'upstream-able' branch.