search

polymerdao / monomer

Build Cosmos SDK applications on the OP Stack.
http://monomer.nethermind.io/
Apache License 2.0
23 stars 16 forks source link

Fix withdrawal address conversion bug #202

Closed natebeauregard closed 1 month ago

natebeauregard commented 1 month ago

Fixes a small bug in the withdrawals flow where cosmos addresses weren't being correctly converted from Bech32 before being converted to their ETH representation.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request focus on modifying the InitiateWithdrawal function within the L2ToL1MessagePasserExecuter struct by changing the sender parameter type from a string to common.Address. This adjustment streamlines the address handling process. Additionally, updates in the storeWithdrawalMsgInEVM function ensure the sender's address is correctly formatted for Ethereum transactions, and the test function has been updated to reflect these changes.

Changes

File Change Summary
bindings/L2ToL1MessagePasserExecuter.go Changed InitiateWithdrawal to accept sender as common.Address instead of a string.
builder/builder.go Added import for sdk and updated address handling in storeWithdrawalMsgInEVM for Ethereum compatibility.
evm/executer_test.go Modified TestL2ToL1MessagePasserExecuter to use common.HexToAddress for sender address initialization.

Poem

🐇 In the meadow where bunnies play,
We fixed the code in a clever way.
With addresses clear, and errors caught,
Our withdrawals now work, as they ought!
Hopping along, we celebrate,
Robustness and joy, oh, isn’t it great? 🐇

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between ae3ec135de70e9c39ff1335a69320a5c5c53ec6d and 61753c3b1d376c02f7a9845407dfcf79ce76c28b.
Files selected for processing (3) * bindings/L2ToL1MessagePasserExecuter.go (2 hunks) * builder/builder.go (2 hunks) * evm/executer_test.go (3 hunks)
Files skipped from review as they are similar to previous changes (2) * bindings/L2ToL1MessagePasserExecuter.go * evm/executer_test.go
Additional comments not posted (2)
builder/builder.go (2)
`12-12`: **LGTM!** The import statement is approved. --- `340-347`: **LGTM!** The code changes are approved for the following reasons: - The conversion from Bech32 to Cosmos address using `sdk.AccAddressFromBech32` ensures the sender's address is in the correct format. - Transforming the Cosmos address to Ethereum address format using `common.BytesToAddress` enhances compatibility with the Ethereum state. - The changes fix the address conversion bug and improve the reliability of the withdrawals feature.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.