Update mockgen dependency

AnkushinDaniil commented 1 month ago

This pull request updates gomock from the unmaintained repo to the maintained fork.

Summary by CodeRabbit

New Features
- Enhanced mock generation process for improved efficiency across multiple files.
- Added a directive for easy mock generation of the BankKeeper interface.
Bug Fixes
- Updated the mocking framework to a more modern library, ensuring better compatibility and performance.
Refactor
- Standardized parameter naming in mock implementations for improved readability.
- Updated installation commands for mock generation tools to ensure the latest versions are used.

AnkushinDaniil commented 1 month ago

@natebeauregard

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve modifications to the Makefile and several Go files within the x/rollup package. The install-mockgen target in the Makefile was updated to install the mockgen tool from a new source. The gen-mocks target was changed to use go generate ./..., allowing broader mock generation. Import paths for the gomock package were changed from github.com/golang/mock/gomock to go.uber.org/mock/gomock. Additionally, the mock implementations in expected_keepers_mocks.go were updated for consistency in parameter naming.

Changes

File(s)	Change Summary
Makefile	Updated `install-mockgen` to install `mockgen` from `go.uber.org/mock/mockgen@v0.4.0`; modified `gen-mocks` to use `go generate ./...`.
x/rollup/keeper/keeper_test.go	Changed import from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/rollup/testutil/expected_keepers_mocks.go	Updated function signatures for consistency in parameter naming; changed import path for `gomock`.
go.mod	Added dependency on `go.uber.org/mock v0.4.0` and removed indirect dependency on `go.uber.org/mock v0.3.0`.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Makefile
    participant GoGenerate
    participant MockGenerator

    Developer->>Makefile: Run `make gen-mocks`
    Makefile->>GoGenerate: Execute `go generate ./...`
    GoGenerate->>MockGenerator: Generate mocks for all relevant files
    MockGenerator-->>GoGenerate: Mocks generated successfully
    GoGenerate-->>Makefile: Generation complete
    Makefile-->>Developer: Mocks are ready for use

Poem

In the meadow where code does play,
A rabbit hops, hip-hip-hooray!
Mocks are now easier, oh what a sight,
With names so clear, they bring delight!
From gomock to uber, a leap we take,
Generating joy, for testing's sake! 🐇✨

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 66bd00c6578aee76c1f7a13bb62a95f4673b3e96 and 622026446b73a8472648a35d4652f7debea4d701.

Files ignored due to path filters (1)

* `go.sum` is excluded by `!**/*.sum`

Files selected for processing (4)

* Makefile (1 hunks) * go.mod (1 hunks) * x/rollup/keeper/keeper_test.go (1 hunks) * x/rollup/testutil/expected_keepers_mocks.go (6 hunks)

Files skipped from review due to trivial changes (1)

* x/rollup/keeper/keeper_test.go

Files skipped from review as they are similar to previous changes (2)

* Makefile * x/rollup/testutil/expected_keepers_mocks.go

Additional comments not posted (1)

go.mod (1)
`35-35`: **Upgraded `go.uber.org/mock` to v0.4.0 and made it a direct dependency.** This change upgrades the `go.uber.org/mock` library from v0.3.0 to v0.4.0 and makes it a direct dependency. Please verify that the existing mock implementations and usages are compatible with the new version, as there might be breaking changes between v0.3.0 and v0.4.0. Making the dependency direct is a good practice to ensure control over the exact version used.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

polymerdao / monomer