polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.22k stars 106 forks source link

Going back to history crashes the app #246

Closed breaking-loss closed 1 year ago

breaking-loss commented 1 year ago

Checklist

Affected version

0.23.3

Steps to reproduce the bug

  1. Go to history
  2. Click on most watched
  3. Click on a video
  4. Repeat this for some more videos
  5. Go back to history

Expected behavior

The expected behavior is that the history should remain in most watched and clicking on a video will open it

Actual behavior

The actualbehavior is that the history reverts back to last played and the app crashes .

Screenshots/Screen recordings

No response

Logs

Exception

java.lang.IllegalStateException: ViewHolder views must not be attached when created. Ensure that you are not passing 'true' to the attachToRoot parameter of LayoutInflater.inflate(..., boolean attachToRoot)
    at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7297)
    at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6416)
    at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288)
    at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345)
    at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361)
    at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368)
    at androidx.recyclerview.widget.GapWorker.run(GapWorker.java:399)
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:201)
    at android.os.Looper.loop(Looper.java:288)
    at android.app.ActivityThread.main(ActivityThread.java:7872)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:550)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)


Affected Android/Custom ROM version

Android 12 / Corvus os 3.0

Affected device model

Redmi 6 pro

Additional information

No response

Atemu commented 1 year ago

How does upstream NewPipe behave here?

breaking-loss commented 1 year ago

I mainly use sponsor block but from my short test newpipe doesn't crash .I haven't tested that much but if I encounter it I will update .

breaking-loss commented 1 year ago

Newpipe crashed .

breaking-loss commented 1 year ago

Newpipe closed my issue as it was duplicate

Atemu commented 1 year ago

This can be closed as a duplicate aswell then. Follow the original upstream issue for updates.

breaking-loss commented 1 year ago

Doesn't matter if the issue gets fixed .

breaking-loss commented 1 year ago

Anyway thanks for replying