polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.24k stars 106 forks source link

Sponsorblock does not work in background play #257

Open Fehertukor opened 1 year ago

Fehertukor commented 1 year ago

Checklist

Affected version

0.24.0

Steps to reproduce the bug

Hello,

I play some videos in the background during work and with the least update the Sponsors are back!...:) Please check this for me. What I do:

  1. Long press video in list -> start playing in the background (same happens when push (background) button in video "description")
  2. Does not skip sponsor, like in video mode.

Example: https://www.youtube.com/watch?v=3qb1pMeAqVg

Expected behavior

To skip sponsors as it did.

Actual behavior

Does not skip

Screenshots/Screen recordings

No response

Logs

No crach

Affected Android/Custom ROM version

Android 11

Affected device model

No response

Additional information

No response

CounterContradiction commented 1 year ago

Can confirm this bug exists following the steps. Another way to see this bug is to use the background button on a playlist. Sponsorblock does work if using the background button under the video.

Screenshot_20221019-192636

Screenshot_20221019-192718

Screenshot_20221019-192652

Fehertukor commented 1 year ago

Thanks! I didn't know!

CounterContradiction commented 1 year ago

Why did you close it? It's a real bug. I just added more info so that hopefully it'll be fixed next version. AFAIK, Sponsorblock does work on all three cases prior to this version (24.0)

Fehertukor commented 1 year ago

Miss click

Fehertukor commented 1 year ago

I will try, thanks!

pickly-spec commented 1 year ago

This particular issue is still not resolved after the latest update, and is not affected by switching the api url to a mirror

g1t3m commented 1 year ago

I can attest to this issue still being unresolved following the latest update as portions of videos highlighted by Sponsorblock still do not skip when "Start playing in the background" or "Enqueue (next)" is selected from the secondary menu. I even tested to see if the third case @CounterContradiction mentioned was affected and it seems that no longer works as well.

g1t3m commented 1 year ago
Screenshot_20221227-085035

Background icon is pressed for single video

Screenshot_20221227-085429

Background icon pressed on channel page

Screenshot_20221227-085735

Enqueue button is pressed on secondary menu

CounterContradiction commented 1 year ago

@g1t3m I forgot to mention it in my comment, but for sponsorblock to work, you have to let the video play first before pressing the background button.

Fehertukor commented 1 year ago

I can testify that for a temporary solution (for sponsorblock in background play), starting the video in "normal" play than switching to background play works(but not consistently).

qwrwed commented 1 year ago

I have also run into this issue on Android 11. Sponsors (non-music segments, in my case) are not skipped in the background unless the video is first played in the foreground.

shadyx49 commented 1 year ago

bump

Fehertukor commented 1 year ago

@polymorphicshade Would this solution possible? (I know maybe it is weird solution). When we click on background play it starts the video in 144p for 1-2 seconds(in the background)/grabs the sponsor skip data/ and than switch automatically to the real background play. Possibly leave it as an option in the settings for those who want it to work for now.

Thank you for your work and everybody who works on this project!

Mobious commented 1 year ago

This is apparently still an issue in version 0.25.1

TalkSickWaist commented 10 months ago

Still an issue. Any chance someone wants to spend a few minutes hacking away at this over the weekend? 🙃

hetszunyukapanyanyimonyok commented 8 months ago

Any news about this? Because I have the same issue.

ihatemakinganaccount commented 8 months ago

Still no solution I see, but at least a workaround: start playing a video normally or in popup, and then switch it to background. SB will work for all the videos in the playlist, even if you keep adding new videos. It'll only stop of you start a new background playback from scratch.