polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.22k stars 106 forks source link

Settings and database import from newpipe bug #266

Closed killerrook closed 1 year ago

killerrook commented 1 year ago

Checklist

Affected version

0.24.0

Steps to reproduce the bug

  1. Open official new pipe app
  2. Export settings by clicking content>export database
  3. Open new pipe sponsor block app
  4. Import database

Note:

  1. It doesn't matter whether you choose to import setup database only or database with settings
    1. It doesn't matter if you enable sponsor block before or after the import

Expected behavior

Database should be imported and app should work fine

Actual behavior

Sponsor block stops working entirely

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Color OS v6.0(android 9)

Affected device model

Oppo Realme 1 CPH1861

Additional information

Sponsor block and other features work as intended if nothing is imported.

Atemu commented 1 year ago

Well it probably disables SponsorBlock in the settings since those settings aren't set in regular NewPipe and off by default in ours.

This looks like it's working as intended. Is the setting on for you after import?

killerrook commented 1 year ago

Nope it doesn't work no matter how many times you try to switch sponsor block on or off after importing database from a official new pipe app

Atemu commented 1 year ago

SB is currently experiencing issues FYI: https://status.sponsor.ajay.app/

killerrook commented 1 year ago

Thanks for telling me know the issue is now resolved. It works both with importing database only or importing database with settings. Closing this issue now