polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.22k stars 106 forks source link

Add a disable sponsorblock switch #271

Closed killerrook closed 1 year ago

killerrook commented 1 year ago

Checklist

Feature description

If you have to disable all categories(sponsors, intro/outro, etc) of sponsor block you have to remove the api link manually else the player will still fetch sponsor block segments from the server which will result in extra mobile data consumption for no good reason. Currently only skip sponsor toggle is available which only toggles the sponsor category in all categories.

The toggle should be also available somewhere in the video player 'request for information' screen for ease of access.

Why do you want this feature?

Mobile data efficiency. Also it's time consuming to remove api link manually.

Why ist the feature relevant to this fork?

Sponsor block

Additional information

No response

Midou36O commented 1 year ago

The toggle should be also available somewhere in the video player 'request for information' screen for ease of access.

Fyi there is a disable sponsorblock button when you go full screen and press the arrow on the top right :)

Atemu commented 1 year ago

@Midou36O does that still contact the sponsorblock servers? That's what @Master2050 is concerned about.

Midou36O commented 1 year ago

From what i can see no, it just stops skipping segments. But i do believe that if you're using this fork you're supposed to want that feature, and for cellular data, i'm pretty sure that videos are more concerning than connecting to a database (O.o)

Atemu commented 1 year ago

@Midou36O they might be listening to audio. Though even then sponsorblock fetches would be of no concern.

killerrook commented 1 year ago

does that still contact the sponsorblock servers? That's what @Master2050 is concerned about

Indeed I was talking about this. Upon analysis of pcap files the app doesn't seem to communicate with sponsorblock servers as of now. Closing this issue now.