polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.22k stars 106 forks source link

crash when running downloaded audio #272

Closed truong0235 closed 1 year ago

truong0235 commented 1 year ago

Checklist

Affected version

newest

Steps to reproduce the bug

open app go to download run an audio app crashes and reopens with error page

Expected behavior

No response

Actual behavior

No response

Screenshots/Screen recordings

No response

Logs

Exception

java.lang.SecurityException: UID 10319 does not have permission to content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Fnewpipe%2FRex%20Incognito.m4a [user 0] [prefix]; you could obtain access using ACTION_OPEN_DOCUMENT or related APIs
    at android.os.Parcel.createExceptionOrNull(Parcel.java:2376)
    at android.os.Parcel.createException(Parcel.java:2360)
    at android.os.Parcel.readException(Parcel.java:2343)
    at android.os.Parcel.readException(Parcel.java:2285)
    at android.app.IActivityTaskManager$Stub$Proxy.startActivity(IActivityTaskManager.java:3969)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1734)
    at android.app.Activity.startActivityForResult(Activity.java:5430)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:597)
    at android.app.Activity.startActivityForResult(Activity.java:5388)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:583)
    at android.app.Activity.startActivity(Activity.java:5774)
    at android.app.Activity.startActivity(Activity.java:5727)
    at org.schabi.newpipe.util.external_communication.ShareUtils.openIntentInApp(ShareUtils.java:157)
    at us.shandian.giga.ui.adapter.MissionAdapter.openExternally(MissionAdapter.java:386)
    at us.shandian.giga.ui.adapter.MissionAdapter.-$$Nest$mopenExternally(Unknown Source:0)
    at us.shandian.giga.ui.adapter.MissionAdapter$ViewHolderItem.lambda$new$1(MissionAdapter.java:933)
    at us.shandian.giga.ui.adapter.MissionAdapter$ViewHolderItem.$r8$lambda$PAQE6UWV_7gFHr9RCCIksMCusOo(Unknown Source:0)
    at us.shandian.giga.ui.adapter.MissionAdapter$ViewHolderItem$$ExternalSyntheticLambda0.onClick(Unknown Source:2)
    at android.view.View.performClick(View.java:7735)
    at android.view.View.performClickInternal(View.java:7712)
    at android.view.View.access$3600(View.java:848)
    at android.view.View$PerformClick.run(View.java:28971)
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:237)
    at android.app.ActivityThread.main(ActivityThread.java:8114)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:963)
Caused by: android.os.RemoteException: Remote stack trace:
    at com.android.server.uri.UriGrantsManagerService.checkGrantUriPermissionUnlocked(UriGrantsManagerService.java:1290)
    at com.android.server.uri.UriGrantsManagerService.checkGrantUriPermissionFromIntentUnlocked(UriGrantsManagerService.java:628)
    at com.android.server.uri.UriGrantsManagerService.access$1000(UriGrantsManagerService.java:121)
    at com.android.server.uri.UriGrantsManagerService$LocalService.checkGrantUriPermissionFromIntent(UriGrantsManagerService.java:1463)
    at com.android.server.wm.ActivityStarter$Request.resolveActivity(ActivityStarter.java:589)


Affected Android/Custom ROM version

MIUI poco rom

Affected device model

Poco c40

Additional information

No response

Atemu commented 1 year ago

You haven't given the app permission for the directory you're trying to download to. This has nothing to do with our fork.

truong0235 commented 1 year ago

@Atemu still getting crash after give app storage perm

Atemu commented 1 year ago

How does upstream NewPipe behave?

truong0235 commented 1 year ago

same result so shoud i close this and bring this one to upstream one on github?

Atemu commented 1 year ago

Yes.

killerrook commented 1 year ago

It has nothing to do with this fork @truong0235 would you close this issue and create your new issue in official new pipe repository?