Sponsor block chapters - Githubissues

polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.

GNU General Public License v3.0

3.22k stars 106 forks source link

Sponsor block chapters #281

Open venkat2305 opened 1 year ago

venkat2305 commented 1 year ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

Sponsorblock introduced chapers support.

Why do you want this feature?

It makes the video watching experience better and we can see the chapters (if contributed by the community) even if the video uploader doesn't add timestamps

Why ist the feature relevant to this fork?

Because it's a sponsor block feature

Additional information

No response

Midou36O commented 1 year ago

Would that require having an account that have paid for the feature or would it simply just work? (This is considered cracking, unless Ajayy explicitly permits it) 🤔

venkat2305 commented 1 year ago

don't know. chapters are enabled on mine. didn't have to pay anything. Is it a paid feature?

Midou36O commented 1 year ago

It is a paid feature, unless it recently went free, but i've yet have to see that (my sb extension on librewolf seems to still require me to pay to be able to access it.)

venkat2305 commented 1 year ago

can you check , if you can see any chapters on this video

Midou36O commented 1 year ago

Nothing shows up

venkat2305 commented 1 year ago

can you check on chrome?

Midou36O commented 1 year ago

No, really, nothing, even the sponsorblock extension shows the lock icon (I just installed sponsorblock on a test clean chromium profile)

venkat2305 commented 1 year ago

ok. @polymorphicshade if it's a paid featyre. there's no point in adding this

Midou36O commented 1 year ago

Not exactly, it can be a nice bonus for those who wish to use it and paid for it.

polymorphicshade commented 1 year ago

I agree with @Midou36O, though chapter support won't be available in Tubular for a while.

DraconicNEO commented 1 year ago

It is a paid feature, unless it recently went free, but i've yet have to see that (my sb extension on librewolf seems to still require me to pay to be able to access it.)

it's a paid feature but only for the extension, the API doesn't have a paywall so the developers of other clients are free to implement it if they choose.

DraconicNEO commented 1 year ago

Would that require having an account that have paid for the feature or would it simply just work? (This is considered cracking, unless Ajayy explicitly permits it) 🤔

the API is open access so technically anyone can implement it if they want. The license check is done through the extension.

Midou36O commented 1 year ago

I guess we will need @Ajayyy to clarify some things :P

ajayyy commented 1 year ago

Yes, as explained in the API docs, you are allowed to use the API in third party clients for free.