polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.21k stars 104 forks source link

Skip several sponsor segments at once if they are next to each other (or close to each other) #320

Open HFPasfho opened 1 year ago

HFPasfho commented 1 year ago

Checklist

Feature description

If two (or more) sponsor segments blocked by SponsorBlock are next to each other (or less than e.g. 2 seconds apart) all of them will be skipped at once (from first start time to last end time).

Why do you want this feature?

Now if two or more sponsor segments are next or close to each other first the playback is stopped, the first segment is skipped, the toast notification is shown, the playback is resumed for a split second just long enough to play a single syllable through speakers/headphones, then the playback stops again, the second segment is skipped, toast notification is shown...

Why ist the feature relevant to this fork?

I block all sponsor segments possible so this unpleasant for ears situation is quite common especially while watching some greedy youtubers with poor content to sponsors/merch/self promotion/collaboration/notification bells/begging of subs/etc. ratio. It also unnecessarily prolongs the whole process of skipping segments. Skipping them all at once would be faster, wouldn't produce obnoxious cracking sounds in headphones and ultimately would lead to much better user experience.

Additional information

No response

HFPasfho commented 1 year ago

@polymorphicshade What does tubular label mean?

polymorphicshade commented 1 year ago

It means I'm planning on doing this in the tubular branch (as opposed to the sponsorblock one).

HFPasfho commented 1 year ago

@polymorphicshade I don't know what tabular branch is but what is the point of not including this change in sponsorblock branch when this concern sponsorblock operation? I'm confused.