New Pipe Sponsor Block isn't responding! Even though the app is working fine this dialogue box keeps appearing, forcing me to close the app. Please check on this. My phone is Moto G73 5g. Thank you :)

polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.

GNU General Public License v3.0

3.23k stars 106 forks source link

New Pipe Sponsor Block isn't responding! Even though the app is working fine this dialogue box keeps appearing, forcing me to close the app. Please check on this. My phone is Moto G73 5g. Thank you :) #330

Open Ksanbah opened 1 year ago

Ksanbah commented 1 year ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I am not able to reproduce the bug with the same version of upstream NewPipe.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

0.25.1

Steps to reproduce the bug

Open app
Play a video
Wait for "NewPipe SponsorBlock isn't responding" with options "close app" and "wait" to appear for no obvious reason.

Expected behavior

The video should just play normally.

Actual behavior

This pop-up box appears and ruins the experience no matter how many times you tap "wait" it keeps appearing, forcing you to tap "close app", closing the app.

Screenshots/Screen recordings

No response

Logs

Screenshot_20230514-072357

Affected Android/Custom ROM version

Android 13

Affected device model

Motorola G73 5g

Additional information

No response

Atemu commented 1 year ago

How does upstream NewPipe behave?

Ksanbah commented 1 year ago

As normal. This strange bug only occurs in your Fork.

anonymousx97 commented 1 year ago

yes newpipe sponsorblock version (upstream is fine.) keeps going into ANR state when you have an instance open and you play another video on top of it...

steps to reproduce: open newpipe and play something. now play something else / share link to media player. once it starts playing the new video, it should go into infinite ANR state even though app is working fine.

screen recording of the bug: https://graph.org/newpip-bug-05-26 video is sped up due to file size restrictions.

Atemu commented 1 year ago

Given that I am not experiencing this issue, we'll need to figure out what the differences between our setups are.

Please provide more detail about:

Operating system
Device
System settings (dev settings: show background ANRs?)
App settings

Back up your settings etc. via the export function and clear the app data. Does the bug still occur with default settings? If not, what do you need to turn on for the bug to occur again?

anonymousx97 commented 1 year ago

OS: Pixel experience Plus - Android 13 Device: Redmi note 8 pro Developer options is disabled.

I cleared newpipe data after exporting my settings and while trying to recreate previous bug I had this crash: https://pastebin.com/9PDnSjWu i played 3-4 videos by sharing links to media player and newpipe stacked them on top of one another, when i pressed back it tried to navigate back to previously played video and crashed. It always is crashing while going back to previously played video in current session.

I was able to reproduce the ANR bug using the steps mentioned in earlier comment using these settings see if it behaves the same for you after importing them. https://oshi.at/jqWM

it also crashed once again after going into ANR, the log was same as the one i linked earlier.

ps: I had to play 4-5 videos back to back to reproduce ANR bug this time (prolly coz I'm playing songs and not full videos) but it usually happens on 2nd video played while watching longer videos, I've faced it many times where after I'm done watching something and i play another it goes into ANR.

Atemu commented 1 year ago

@anonymousx97 could you provide reproduction steps from an empty config/fresh install to ANR?

A video would be fine; just upload here right on Github at full length and regular speed. It's hard to tell what's going on in your original video.

anonymousx97 commented 1 year ago

@Atemu I was not able to upload the video here so uploaded to: https://oshi.at/cjHo

I managed to record 2 crashes and 1 ANR in the video. hope that's enough to reproduce it on your end.

Atemu commented 1 year ago

Could you try to repro with default settings? (Not even sponsorblock.)

anonymousx97 commented 1 year ago

@Atemu hi! sorry for delayed the response; i turned off sponsorblock while keeping other settings in the video as is and I got ANR once i finished watching a video and then played another one.

then

i clear newpipe's data and didn't change any settings and started using it as i would normally use like mentioned earlier i.e play videos one after another. after watching more than 3-4 videos it did not go into ANR state. So either one of the settings i turned on is causing the ANR or sponsorblock is. i think its the start video in full screen and pause video on minimise setting might be causing the ANRs.

Atemu commented 1 year ago

I suspected something like that might be the case. Turn on settings one-by-one to find out which one causes the issue.

Then also try turning that same set of settings on in regular upstream to see whether this is actually a bug on our side or not.

anonymousx97 commented 1 year ago

@Atemu upstream doesn't have these issues. i cleared all data of sponsorblock version and set minimise player action to None, it started giving ANR on app switch and crashed 2 times. logs are the same ones i submitted earlier.

YourFin commented 1 year ago

I can confirm that this is an upstream issue. I've been having the same symptoms for a long time, and only just discovered this fork.