Sponsorblock not working

polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.

GNU General Public License v3.0

3.2k stars 104 forks source link

Sponsorblock not working #367

Open maxkraft7 opened 1 year ago

maxkraft7 commented 1 year ago

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I am not able to reproduce the bug with the same version of upstream NewPipe.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug.
[X] I have read and understood the contribution guidelines.

Affected version

25.2

Steps to reproduce the bug

Go to a video that has sponsors annotated

Expected behavior

Skip the ads and show a green color in the seek bar

Actual behavior

None of that, just the default NewPipe behaviour

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 12

Affected device model

Oneplus Nord

Additional information

No response

Atemu commented 1 year ago

Can't reproduce. What are your settings?

AnimeWaifuGirl commented 1 year ago

i can't find anything over sponsoreblock in the settings of the newpipe app self! yes i used the search function in the settings but nothing founded by the search

Atemu commented 1 year ago

@AnimeWaifuGirl are you using this fork or the regular upstream NewPipe?

MateusAuri commented 1 year ago

Maybe you put in the wrong API URL in the settings? I was having the same issue until I stared at the gifs in the README.md and noticed I had typed https://sponsor.ajay.app instead of https://sponsor.ajay.app/api/ (because I had copied it from FreeTube). Adding the "/api/" solved it for me. Otherwise you can click the question icon right next to it, and then "USE OFFICIAL".

valtoree commented 1 year ago

Me too have the /api/ setting. Here is an example https://www.youtube.com/watch?v=8t9_S9Ok1_A&t=1m34s Doesn't skip when sponsor comes on 🤷 Android 14, grapheneos

Tried on sky tube app, same thing. I assume it's a sponsor block thing then.

Atemu commented 1 year ago

This video simply doesn't have any sponsored sections marked. Keep in mind that sponsorblock relies on 100% croud-sourced information. People manually enter these.

valtoree commented 1 year ago

Update: now its working. Must be what you said about people manually adding this in. Therefore latest videos might not yet be updated yet. For me this is solved. Ty @Atemu

allanlaal commented 1 year ago

@polymorphicshade why not prefill the Sponsorblock API url? shall I make a PR? :)

Atemu commented 1 year ago

This is intentional because the user needs to accept the Sponsorblock service's privacy policy. Filling in the URL to their servers serves as an explicit declaration of consent.

If you'd prefer to accept some other sponsorblock server's terms over the "official" one's, you could fill in a different URL here.

AnimeWaifuGirl commented 1 year ago

@AnimeWaifuGirl are you using this fork or the regular upstream NewPipe?

sure i use the latest version from github release but in this version dosent existing a sponsorblock function!