Upstream has released v0.26.1

cohesive-flight commented 7 months ago

Checklist

[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have read the FAQ and my problem isn't listed.
[X] I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
[X] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
[X] This issue contains only one feature request.
[X] I have read and understood the contribution guidelines.

Feature description

v0.26.1

Why do you want this feature?

The like count has been fixed, live streams are viewable from the channel page now, and more.

Why is the feature relevant to this fork?

It's a new release from this fork's upstream.

Additional information

No response

DI555 commented 7 months ago

guys, come on, give it a few days, mb some little bugs, crushes, polishes or uncompatibilities.., you know.

baalajimaestro commented 7 months ago

https://git.baalajimaestro.me/baalajimaestro/NewPipe/releases/download/v0.26.0/app-release.apk

Try using this, u might need to reinstall the app though. Since it is signed with my keys

SyCoREAPER commented 7 months ago

Is it really worth the effort? I'd rather dev(s) take the time to mentally prep for the major rewrite of the main Newpipe

johanw666 commented 7 months ago

Update can go to 0.26.1 now.

I'd rather dev(s) take the time to mentally prep for the major rewrite of the main Newpipe

I don't know how much work it is to patch the sponsorblock changes into NewPipe.

SyCoREAPER commented 7 months ago

Update can go to 0.26.1 now.

I'd rather dev(s) take the time to mentally prep for the major rewrite of the main Newpipe

I don't know how much work it is to patch the sponsorblock changes into NewPipe.

You mean in terms of the current codebase I assume? Even so, small changes upstream can have consequences downstream.

Neverthelesa of of much or how little time it takes, it's time the team takes from their private lives and provides to us for free.

By now the Internet should know that it's improper to ask when an update is coming for something free. Buying a AAA and pestering the devs for bug fixes is one thing, but a free app or program it's bad etiquette.

cohesive-flight commented 7 months ago

guys, come on, give it a few days, mb some little bugs, crushes, polishes or uncompatibilities.., you know.

I waited about three days before making this issue. The maintainer usually updates this fork within the same day upstream makes a release, so I thought they might've not noticed. But if there are issues with the new changes, then of course they can take as long as they want to fix it. However, considering @baalajimaestro made a release of their own by only pulling changes from upstream, the maintainer is most likely not aware of it, or is very busy.

Is it really worth the effort? I'd rather dev(s) take the time to mentally prep for the major rewrite of the main NewPipe

This fork's maintainer doesn't work with the developers of NewPipe, so he's not contributing to the rewrite. And even if they did, the developers still made a release (now two) despite doing so. Therefore, it's not out of the question for this fork to also make a new release when upstream does.

Neverthelesa of of much or how little time it takes, it's time the team takes from their private lives and provides to us for free.

By now the Internet should know that it's improper to ask when an update is coming for something free. Buying a AAA and pestering the devs for bug fixes is one thing, but a free app or program it's bad etiquette.

Of course. I only made this issue to make the maintainer aware that upstream made a new release(s).

lsomm commented 7 months ago

Would it make sense to create a PR for this, so that the maintainer can just verify and accept it?

Atemu commented 7 months ago

@polymorphicshade has previously mentioned that they prefer to do the pull themselves.

To provide some background: The pull is usually either trivial to the point where it's quicker to just do it rather than review someone else doing the same or it's non-trivial requiring thorough care to be taken by someone very familiar with the code (in other words: Poly).

polymorphicshade / NewPipe