polymorphicshade / Tubular

A fork of NewPipe that implements SponsorBlock and ReturnYouTubeDislike.
GNU General Public License v3.0
1.11k stars 24 forks source link

Fix unskip on certain segment #48

Closed mikooomich closed 2 months ago

mikooomich commented 3 months ago

Hewwo! This address an bug where unskip functionality may break (where you trigger unskip but it automatically re-skips anyways) when two segments are very close to each other (I think). I am not exactly sure of the cause, however it applies to certain videos. See 3:15:00 --> https://www.youtube.com/live/1ThO140eQY4?si=Vpb9A5eE7xeK2cuf&t=11700

Code wise, it separates hiding buttons and the destruction of unskip tracking variables. I believe this also is present on release versions, but my memory is fuzzy.