polymorphicshade / Tubular

A fork of NewPipe that implements SponsorBlock and ReturnYouTubeDislike.
GNU General Public License v3.0
1.11k stars 24 forks source link

Sorry Something went Wrong #53

Closed GeneralWarPig closed 2 months ago

GeneralWarPig commented 2 months ago

Checklist

Affected version

0.26.1_r3

Steps to reproduce the bug

rotating the screen

Expected behavior

No error

Actual behavior

Constant "Sorry, something went wrong" spamming everytime I rotate the screen.

Screenshots/Recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 14 / One UI 6.1

Affected device model

Galaxy S23 Ultra

Additional information

No response

polymorphicshade commented 2 months ago

@GeneralWarPig Does this happen on vanilla NewPipe?

GeneralWarPig commented 2 months ago

Yes, it use to do the same thing but I was able to turn the error off in the sponsor block version.

On Mon, Apr 8, 2024, 5:29 PM poly @.***> wrote:

@GeneralWarPig https://github.com/GeneralWarPig Does this happen on vanilla NewPipe?

— Reply to this email directly, view it on GitHub https://github.com/polymorphicshade/Tubular/issues/53#issuecomment-2043745066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH65OVRUJUCOPC2KMWNYUHLY4MK4JAVCNFSM6AAAAABF5PIEEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTG42DKMBWGY . You are receiving this because you were mentioned.Message ID: @.***>

hjc25 commented 2 months ago

Yup, same here, every video I select gives that, with a report button as well. Ignoring it, playback is fine.

Screenshot_20240410-220203

`## Exception

java.lang.RuntimeException: Failure from system
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1814)
    at android.app.Activity.startActivityForResult(Activity.java:5506)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:712)
    at android.app.Activity.startActivityForResult(Activity.java:5464)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:693)
    at android.app.Activity.startActivity(Activity.java:5854)
    at android.app.Activity.startActivity(Activity.java:5807)
    at org.schabi.newpipe.error.ErrorUtil$Companion.openActivity(ErrorUtil.kt:43)
    at org.schabi.newpipe.error.ErrorUtil$Companion.showSnackbar$lambda$0(ErrorUtil.kt:149)
    at org.schabi.newpipe.error.ErrorUtil$Companion.$r8$lambda$hbVLiP6-HtFc17h3_yyNDsmaIY8(ErrorUtil.kt:0)
    at org.schabi.newpipe.error.ErrorUtil$Companion$$ExternalSyntheticLambda0.onClick(R8$$SyntheticClass:0)
    at com.google.android.material.snackbar.Snackbar.lambda$setAction$0(Snackbar.java:352)
    at com.google.android.material.snackbar.Snackbar.$r8$lambda$4rINiMZz55Dc47hSTCuz-ALWyEw(Snackbar.java:0)
    at com.google.android.material.snackbar.Snackbar$$ExternalSyntheticLambda1.onClick(R8$$SyntheticClass:0)
    at android.view.View.performClick(View.java:7467)
    at android.view.View.performClickInternal(View.java:7444)
    at android.view.View.access$3700(View.java:840)
    at android.view.View$PerformClick.run(View.java:28831)
    at android.os.Handler.handleCallback(Handler.java:978)
    at android.os.Handler.dispatchMessage(Handler.java:104)
    at android.os.Looper.loopOnce(Looper.java:238)
    at android.os.Looper.loop(Looper.java:357)
    at android.app.ActivityThread.main(ActivityThread.java:8090)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1026)
Caused by: android.os.TransactionTooLargeException: data parcel size 1242024 bytes
    at android.os.BinderProxy.transactNative(Native Method)
    at android.os.BinderProxy.transact(BinderProxy.java:571)
    at android.app.IActivityTaskManager$Stub$Proxy.startActivity(IActivityTaskManager.java:2371)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1808)
    ... 25 more


`

flashymittens commented 2 months ago

I often see the same error when starting playback if comments are enabled (and they fail to load as a result). Unsure if it's the same thing, but just in case.

don-dolarson commented 2 months ago

Same here. Problem with "Sorry, something went wrong." when comments are activated, resulting in comments not loading. It behaves like that for both NewPipe SponsorBlock for and now Tubular.

bioblatt commented 2 months ago

same issue with enabled comments for me

Exception

java.lang.RuntimeException: Failure from system
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1885)
    at android.app.Activity.startActivityForResult(Activity.java:5572)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:712)
    at android.app.Activity.startActivityForResult(Activity.java:5530)
    at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:693)
    at android.app.Activity.startActivity(Activity.java:6032)
    at android.app.Activity.startActivity(Activity.java:5999)
    at org.schabi.newpipe.error.ErrorUtil$Companion.openActivity(ErrorUtil.kt:43)
    at org.schabi.newpipe.error.ErrorUtil$Companion.showSnackbar$lambda$0(ErrorUtil.kt:149)
    at org.schabi.newpipe.error.ErrorUtil$Companion.$r8$lambda$hbVLiP6-HtFc17h3_yyNDsmaIY8(ErrorUtil.kt:0)
    at org.schabi.newpipe.error.ErrorUtil$Companion$$ExternalSyntheticLambda0.onClick(R8$$SyntheticClass:0)
    at com.google.android.material.snackbar.Snackbar.lambda$setAction$0(Snackbar.java:352)
    at com.google.android.material.snackbar.Snackbar.$r8$lambda$4rINiMZz55Dc47hSTCuz-ALWyEw(Snackbar.java:0)
    at com.google.android.material.snackbar.Snackbar$$ExternalSyntheticLambda1.onClick(R8$$SyntheticClass:0)
    at android.view.View.performClick(View.java:7535)
    at android.view.View.performClickInternal(View.java:7512)
    at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
    at android.view.View$PerformClick.run(View.java:29488)
    at android.os.Handler.handleCallback(Handler.java:984)
    at android.os.Handler.dispatchMessage(Handler.java:104)
    at android.os.Looper.loopOnce(Looper.java:238)
    at android.os.Looper.loop(Looper.java:357)
    at android.app.ActivityThread.main(ActivityThread.java:8088)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)
Caused by: android.os.TransactionTooLargeException: data parcel size 1242032 bytes
    at android.os.BinderProxy.transactNative(Native Method)
    at android.os.BinderProxy.transact(BinderProxy.java:584)
    at android.app.IActivityTaskManager$Stub$Proxy.startActivity(IActivityTaskManager.java:2258)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1879)
    ... 25 more


carnager commented 2 months ago

This is fixed in RC releases of new pipe 0.27

hjc25 commented 2 months ago

This is fixed in RC releases of new pipe 0.27

When will that reach Tubular?

carnager commented 2 months ago

Most likely after it reached a stable release. Which won't happen before the new extractor sees a proper release, I think.

You can watch progress here: https://github.com/TeamNewPipe/NewPipe/issues/10930

mrbigmouth502 commented 2 months ago

NewPipe just released a new stable build, with comment replies to boot. https://github.com/TeamNewPipe/NewPipe/releases/tag/v0.27.0