Closed tchataigner closed 2 years ago
As of now it works with the development started in the repository holium
on the branch feature/ee-interface-get
Ready for second review round. Created a new ticket as discussed for custom serde Serializer
& Deserializer
. @PhilippeMts I'll let you specify implementation method & time estimate it.
Thank you Thomas for your humongous work on this feature and all the answers you provided to my first comments.
As I prove to be unable to provide useful feedback in due times on this PR, I will only ask you to focus on the following points and we may then move forward.
Currently, I may identify a few issues in the way this project is organized:
rust-integration-test
crate with other crates, as it is in fact a test asset more than source code for the SDK.Cargo.toml
file, does not seems like a safe choice.Documentation on workspaces: https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html.
I would thus recommend the following actions:
Create a ./crates/sdk
directory.
Move ./src
and ./Cargo.toml
to ./crates/sdk
.
Remove the [workspace]
section from this Cargo.toml
.
Move ./tests
to ./tests/assets/rust-package
.
Have a new root Cargo.tml
file:
[workspace]
members = [
"crates/sdk",
"crates/macro-support",
"crates/macro",
"crates/backend",
]
Update the README accordingly.
Please we may allow for minor release updates using the ^
character in the holium-macro-support
crate.
./src/internal/data_tree.rs:83
You should handle the memory access in a more secure way, using the key_node.children.get
method.
Mistake on my side while merging, reopening w/ develop
as base !
Ok @PhilippeMts all comments are taken into account ! Thank you !
What It Does 🔎
This PR is a starting point of binding generation for holium transformations developed in Rust. It exposes a procedural macro that will wrap functions with necessary code to run in an Holium runtime.
Documentation Updates 📘
Pull Request
How To Test ✔️
cargo test
Linked Issues 🎫
Related Pull Requests 🔀
Proposition of new issues