search

polyphene / holium-rs-sdk

MIT License
1 stars 0 forks source link

Feature/cli debut #4

Closed tchataigner closed 2 years ago

tchataigner commented 2 years ago

What It Does 🔎

This PR is a starting point of the CLI that goes along the Rust SDK. It proposes two commands, build and info.

build

Builds a rust project as wasm bytecode

info

Fetch used SDK version from a wasm bytecode

Documentation Updates 📘

Documentation update will be added when the branch artifacts-generation is opened for review.

How To Test ✔️

cargo test

Linked Issues 🎫

Related Pull Requests 🔀

Proposition of new issues
PhilippeMts commented 2 years ago

Thanks @tchataigner for this pull request.

My first comment would be about its timing relatively to other issues and features.

Thank you Thomas!

tchataigner commented 2 years ago
  • This PR points to feature/glue-code-generation which is soon to be merged into develop according to this PR. I think we should wait for the latter to be fully merged before proceeding to the formal review of the current PR.

Good point, I agree with your feedback. Let's set the review at a later date, when the feature/glue-code-generation branch is merged.

  • In the Documentation Updates 📘 part of the description, you are talking about a future PR related to a artifacts-generation branch. Could you explain what PR is expected and when it is, how they depend on each other if they do, and in which order they should be reviewed?

The upcoming PR concerns metadata generation for our transformations. It adds a generation of CBOR objects representing our metadata according to #3 . The upcoming PR should be reviewed after this one.

Conclusion:

I am currently focused on development so I won't merge #2 now. I will keep this PR open, rebase it on develop when #2 is merged and open a new PR, based on the feature/cli-debut for feature/artifacts-generation.

tchataigner commented 2 years ago

Closing the PR in favor of another at a later date that will have those feature + metadata generation.