search

polyphony-chat / chorus

A rust library for interacting with multiple Spacebar-compatible Instances at once.
https://crates.io/crates/chorus
Mozilla Public License 2.0
16 stars 7 forks source link

Refactor / fix login and register #495

Closed kozabrada123 closed 2 months ago

kozabrada123 commented 2 months ago

Change login and register to only use one ChorusUser object, change the api somewhat of related methods which were also somewhat ugly

Also see #494

kozabrada123 commented 2 months ago

what do you think? @bitfl0wer specifically, should we even keep Instance::get_user and Instance::get_settings now? (we don't use them internally anymore, maybe get_user sort of makes sense for public api, get_settings probably doesnt)

bitfl0wer commented 2 months ago

Looks great, thanks :) I feel like the two pub methods could be removed. If someone does need them, re-implementing them would not be an issue.