search

polyphony-chat / chorus

A rust library for interacting with multiple Spacebar-compatible Instances at once.
https://crates.io/crates/chorus
Mozilla Public License 2.0
16 stars 7 forks source link

Alternative route for guild deletion #513

Open bitfl0wer opened 2 weeks ago

bitfl0wer commented 2 weeks ago

I have just been made aware of the fact that Spacebars API, which I seem to have based this methods' implementation on, wrongly implemented guild deletion. Apparently, it has been DELETE /guilds/ for years, not POST /guilds//delete, as Spacebar and Chorus have implemented it.

Changing this should be an easy fix - 5 minutes tops. Note, that the Guild deletion test will fail, as the tests are based on the Spacebar server, which is wrongly implemented apparently.

https://github.com/polyphony-chat/chorus/blob/main/src/api/guilds/guilds.rs#L108-L116

bitfl0wer commented 2 weeks ago

The current route isn't wrong. Apparently, Discord supports both routes. v9 Documentation lists the DELETE route, however. Unsure if the change is still required

Quat3rnion commented 2 weeks ago

Well, if discord supports both, then I'll add support for both on symfonia as well