polyphony-chat / chorus

A Rust library for interacting with multiple Polyphony- and Spacebar-Compatible instances at once.
https://crates.io/crates/chorus
Mozilla Public License 2.0
16 stars 7 forks source link

Types change causes build error in Symfonia #523

Closed kozabrada123 closed 1 month ago

kozabrada123 commented 2 months ago

I'm guilty of this of course, just opening it up to an issue to track it better

Pr #514 causes a build error in Symfonia by changing pub theme_colors: Option<Vec<u8>>, to pub theme_colors: Option<Vec<u32>>,, since Vec<u8> can be encoded by Sqlx but Vec<u32> cannot.

An ideal solution to this would bring include a new type for theme colors, with a custom Sqlx encoding implementation. Note that the most accurate representation of theme colors is likely (u32, u32) or [u32; 2]

kozabrada123 commented 2 months ago

Atm this issue prevents Symfonia from updating chorus past commit d591616

bitfl0wer commented 1 month ago

Fixed by #533