search

polyphony-chat / chorus

A Rust library for interacting with multiple Polyphony- and Spacebar-Compatible instances at once.
https://crates.io/crates/chorus
Mozilla Public License 2.0
16 stars 7 forks source link

Event and Eventtype #527

Closed bitfl0wer closed 1 month ago

bitfl0wer commented 1 month ago

I feel like these two Enums should be part of a library like this one, so I added them. :3c

kozabrada123 commented 1 month ago

Hmmm, I originally avoided such an enum in our gateway implementation, since it will almost always be incomplete and adding new variants would be a breaking change to our api

kozabrada123 commented 1 month ago

I think a solution to this would be to annotate both with #[non_exhaustive]

bitfl0wer commented 1 month ago

Closing this. The reason I haven't merged this right away was because I also contemplated whether this would be a good idea. The reason I needed the enum was for something in symfonia - so I just defined it there instead.

kozabrada123 commented 1 month ago

Fair, considering the usage in Symfonia I also think it makes more sense to keep the enums there When we add new events to chorus, Symfonia can also adopt them when it needs emitters for them