search

polyrabbit / hacker-news-digest

:newspaper: Let ChatGPT Summarize Hacker News for You
http://hackernews.betacat.io/
GNU Lesser General Public License v3.0
668 stars 87 forks source link

Descriptions in the RSS sometimes don't include [comments] link #37

Closed bkewl closed 2 days ago

bkewl commented 2 days ago

It seems that the RSS feed.xml doesn't include the [comments] link after [summary].

I think it's when there are 0 comments in the thread, because it seems to show up later. Here's one I caught in the wild which started with no link:

image

Which had no comments:

image

Then later it had the comments link.

image

I think this is fine when reading from the summary page, but if my reader (Feedly) picks up the item while the description doesn't have [comments] I never see it and have to manually navigate to the thread to see if any comments have appeared. For the RSS feed, maybe it just makes sense to always render the comments link here?https://github.com/polyrabbit/hacker-news-digest/blob/e938b54b1e3adec47b2121c5da64d07aca0e44ff/publish.py#L112

Thanks for making this public, by the way. It's my favourite feed!

polyrabbit commented 2 days ago

Thanks for the feedback, now we have links for news with zero comments - https://github.com/polyrabbit/hacker-news-digest/commit/eb874370cad9cba7fdc3611d2b3440a34b810b62

bkewl commented 2 days ago

Amazing, thank you!