polyrhythm-project / polyrhythm-maps

2 stars 0 forks source link

Marker clusters on the composers map #46

Closed ect123 closed 1 year ago

ect123 commented 1 year ago

Marker clusters might be good to include on composers map too.

bel28kent commented 1 year ago

Added marker clusters to composers.html on branch 48.

epoudrier commented 1 year ago

Modify the clusters using Spiderfy. The goal is for points in the same location at the city level are amalgamated preserving the different colour coding for birth and death.

bel28kent commented 1 year ago

@epoudrier @ect123 @craigsapp:

I have added spiderfy to the marker clusters on the composers map. These changes were pushed on Branch #48.

Note that the spiderfy removes the lines we had that connected birth and death locations by composer.

Screen Shot 2023-06-28 at 10 31 41 AM

Also note that the spiderfy lines only seem to be drawn between markers within a certain area of the map at a certain zoom level, so the lines are only being drawn for two clusters in New York, one in Paris, and one in Vienna.

I added spiderfy separately to the birth clusters and the death clusters, so the spiderfy lines are only drawn between green markers or red markers. However, the user has to zoom in to the closest zoom level to see the markers themselves in order to know which markers are being grouped. This means that at farther zoom levels the marker clusters are not communicating anything about the birth or death of composers to the user.

Screen Shot 2023-06-28 at 10 43 59 AM

Lastly, there is some bug with this spiderfied cluster in Vienna. After looking at the metadata, the red dot in the middle appears to be the death place marker for Alban Berg, the only composer in the corpus who died in Vienna. However, the popup will not appear when I click on the dot, no matter what zoom level I am at. Also, the red marker is rendering at a lighter opacity than the other red markers.

Screen Shot 2023-06-28 at 10 49 16 AM
bel28kent commented 1 year ago

Remove marker clusters and spiderfy.

Restrict zoom level on map to prevent user from seeing street level. Zoom level: 11

Distance markers within one city. (@jasonleeubc)

Layers: (1) Only birth and death locations; (2) locations with lines; (3) includes locations of important events during composers' lifetimes.

Ability to see data for composers as selected by user.

bel28kent commented 1 year ago

Documentation for Leaflet layer control: https://leafletjs.com/reference.html#control-layers

epoudrier commented 1 year ago

Point have been manually edited to avoid conflation. Marker clusters will not be used for this map given the small number of points.