search

polyrhythm-project / polyrhythm-website

3 stars 3 forks source link

Remove final barline on most examples #51

Open craigsapp opened 4 years ago

craigsapp commented 4 years ago

All Sibelius examples contain a final barline in the MusicXML data and in the PDFs. There should not be a final barline in the music except in the case where the musical excerpt is at the end of the music it is being extracted from.

There are two possible solutions:

(1) Edit all necessary Sibelius files to remove the double barline (by changing the last measure line to a regular barline), then regenerate the MusicXML files and PDFs from Sibelius.

(2) I can automatically remove final barlines from Humdrum files, and would just need a list of examples that should keep the final barline (if there are any).

(1) is labor intensive and would take quite a while for someone to do.

(2) Is easy to do, and could be done in a few minutes.

@epoudrier can say which way is the best. Mostly it depends on if you want the Sibelius files to closely match the Humdrum conversion from Sibelius. And when there are corrections to the Humdrum, should they also be made in the Sibelius file?

At the moment the MusicXML/Sibelius files and Humdrum files match exactly except for a few manual edits I made (which will probably be lost at this stage as I will need to reconvert for a while to remove the problems reported in the pr website repository issues.

craigsapp commented 4 years ago

All examples now have the final barline removed, such as:

https://polyrhythm.humdrum.org/example/?id=144

Screen Shot 2020-01-22 at 09 12 57

Compare to Sibelius PDF:

Screen Shot 2020-01-22 at 09 14 16
cdf75ubc commented 4 years ago

same for T331

cdf75ubc commented 4 years ago

same for T333

cdf75ubc commented 4 years ago

same for T334

cdf75ubc commented 4 years ago

same for T335

cdf75ubc commented 4 years ago

same for T336

craigsapp commented 4 years ago

What do you mean by "same for", @cdf75ubc ? The problem exists on all examples, so obviously it would be common to all examples (so not interesting to report on an individual basis).

More interesting would be to report cases where the final barline should remain in the example (where it is from the very end of a piece/movement).

epoudrier commented 4 years ago

I have clarified the procedure for repeated issues @cdf75ubc

I agree with Craig applying option (2) above; we will make this a general edit watch for when the Sibelius files get edited (last step of proofreading/editing process).