polyseam / cndi

Self-Host Cloud-Native Apps with the Ease of PaaS
https://cndi.dev
Apache License 2.0
163 stars 6 forks source link

[Bug]: Incrementing EKS node count fails #984

Open johnstonmatt opened 3 weeks ago

johnstonmatt commented 3 weeks ago

Version

cndi v2.16.0 kubeseal v0.26.0 terraform v1.5.5

Please provide a summary of the enhancement you are proposing:

ensure node count can be modified to horizontally scale eks clusters

Please provide the motivation or use case for this enhancement:

This was thought to work already but results in:

# module.cndi_aws_eks_managed_node_group_0.aws_eks_node_group.this[0] will be updated in-place
  ~ resource "aws_eks_node_group" "this" {
        id                     = "mj-hop:x-node-group-20240816034342484700000015"
        tags                   = {
            "CNDIProject" = "mj-hop"
            "Name"        = "x-node-group"
        }
        # (16 unchanged attributes hidden)

      ~ scaling_config {
          ~ max_size     = 3 -> 4
          ~ min_size     = 3 -> 4
            # (1 unchanged attribute hidden)
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.
module.cndi_aws_eks_managed_node_group_0.aws_eks_node_group.this[0]: Modifying... [id=mj-hop:x-node-group-20240816034342484700000015]
╷
│ Error: updating EKS Node Group (mj-hop:x-node-group-20240816034342484700000015) config: operation error EKS: UpdateNodegroupConfig, https response error StatusCode: 400, RequestID: da2ddc94-9dda-4f23-ae6d-20cb954[309](https://github.com/polyseam/mj-hop/actions/runs/10414630910/job/28843872187#step:9:310)bc, InvalidParameterException: Minimum capacity 4 can't be greater than desired size 3
│ 
│   with module.cndi_aws_eks_managed_node_group_0.aws_eks_node_group.this[0],
│   on .terraform/modules/cndi_aws_eks_managed_node_group_0/modules/eks-managed-node-group/main.tf line 384, in resource "aws_eks_node_group" "this":
│  384: resource "aws_eks_node_group" "this" {
│ 
╵

How can we best workaround this issue so far?

No response

How would you approach solving this problem within CNDI?

No response

Code of Conduct

johnstonmatt commented 3 weeks ago

https://github.com/terraform-aws-modules/terraform-aws-eks/issues/835