search

polysoft1 / libmatrix-client

A C++ client for the matrix communication protocol that is designed to not be dependent on specific libraries.
MIT License
2 stars 0 forks source link

Definition Improvements #15

Closed jaredoconnell closed 3 years ago

jaredoconnell commented 3 years ago

USE_CUSTOM_HTTP is the CMake option that was defined higher up in the CMakeLists.txt, so I fixed that.

USE_CPPRESTSDK and USE_CUSTOM_HTTP_SESSION were fairly generic (especially USE_CPPRESTSDK), so I added the prefix POLYTRIX_ to prevent any conflicts.

kdvalin commented 3 years ago

The POLYTRIX_ prefix is problematic, this is a library, not a plugin for PolyChat, we should not be referencing anything other than the project in this repository.

So, I don't know what the best fix for this is, but it certainly isn't referencing POLYTRIX everywhere