Unit tests - Githubissues

polyswarm / relay

Sidechain relay for PolySwarm, the first decentralized threat intelligence market.

https://polyswarm.io

GNU General Public License v3.0

2 stars 1 forks source link

Unit tests #18

Closed mjkoo closed 5 years ago

mjkoo commented 5 years ago

Is your feature request related to a problem? Please describe. We've deferred fleshing out our unit test suite due to API changes and difficulty testing interconnected components in isolation, but it's past time we improve this.

In addition to improving coverage, we should

[x] Include unit tests in CI
[ ] Report coverage from gitlab CI pipeline runs in badge
[ ] Run clippy lints in CI
[x] Ensure cargo fmt clean in CI https://github.com/rust-lang-nursery/rustfmt#checking-style-on-a-ci-server

mjkoo commented 5 years ago

Whats our coverage at and where are the new tests, I dont see a PR

myhndl commented 5 years ago

We can't close this ticket until coverage is calculated CI and badges are in README

myhndl commented 5 years ago

@zv I saw a pull request or something on this today - where are we on this?

myhndl commented 5 years ago

blocked by: https://github.com/polyswarm/relay/issues/13

ceseale commented 5 years ago

@myhndl I don't think this blocked anymore https://github.com/polyswarm/relay/pull/31 fixes the test.

myhndl commented 5 years ago

Oh okay great @ceseale !

@zv please take note.