polyswarm / relay

Sidechain relay for PolySwarm, the first decentralized threat intelligence market.
https://polyswarm.io
GNU General Public License v3.0
2 stars 1 forks source link

Minimize chances of missed withdrawals #24

Closed mjkoo closed 5 years ago

mjkoo commented 6 years ago

Is your feature request related to a problem? Please describe. Right now we watch for transfer events using the subscribe rpc feature, we should more robustly handle any instances where we might miss transfers

Describe the solution you'd like In addition to eth_subscribe, consider one or both of:

Describe alternatives you've considered In order to miss a transfer >1/3 of verifiers would have to miss it, we could increase number of verifiers to decrease this probability with no code changes.

myhndl commented 5 years ago

Spoke with @Rizato , this one is high prio, will move up in column.

Rizato commented 5 years ago

Wrapping this part in from #3 Need to retry failed approve_withdrawals as part of the recovery from missed transfers.

I'm unclear looking at the code what happens if a transaction times out, specifically in the case where a transaction has confirmed on the sidechain and funds are released on mainnet, but gas fees are too high and the tx doesn't confirm. This is mostly theoretical with a 20Gwei default fee, but could result in funds not actually being delivered.