search

polytope-labs / hyperbridge

Hyperbridge is a hyperscalable coprocessor for verifiable, cross-chain interoperability
https://docs.hyperbridge.network/
Apache License 2.0
111 stars 41 forks source link

Make ismp-parachain accessible #132

Closed Szegoo closed 7 months ago

Szegoo commented 7 months ago

I was trying to test reading from other parachains locally when I realized that I couldn't access the ismp-parachain crate. I would assume it was left out by accident in the Cargo.toml file.

Also, there is another unrelated modification in this PR. It was for some reason failing to compile since it couldn't find the parachain-system package, even though in the Cargo.toml it was explicitly noted that it should look for cumulus-pallet-parachain-system.

Szegoo commented 7 months ago

Yeah, will need that as well. While at it, I also added the runtime-api as well

seunlanlege commented 7 months ago

completely stumped as to how to allow workflows run on a fork

Szegoo commented 7 months ago

Weird :/ Some of the CI checks managed to run. I formatted the code, not sure if that could've been causing issues.

seunlanlege commented 7 months ago

Weird :/ Some of the CI checks managed to run. I formatted the code, not sure if that could've been causing issues.

Has to do with GitHub secrets sharing with forks. I've found a few solutions. Will try them out tomorrow

seunlanlege commented 7 months ago

I've merged #135 which should allow CI run on contributor PRs. Not sure if you need to rebase, but if everything fails try to rebase

seunlanlege commented 7 months ago

Alright just going to merge this for now, any other improvements can be done in a follow up PR